Add headless execution #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
Feb 5, 2024
| solc_version = "0.8.23" | ||
| [profile.suave] | ||
| whitelist = ["*"] |
There was a problem hiding this comment.
This info is used by the precompile execution.
ferranbt
commented
Feb 5, 2024
src/Test.sol
Outdated
| revert("Local Suave node not detected running"); | ||
| } | ||
| } catch (bytes memory reason) { | ||
| try vm.ffi(inputs) returns (bytes memory response) {} |
There was a problem hiding this comment.
The suave-geth forge status had two goals:
- Figure out if the
suave-gethbinary was available on PATH. - Check if there was a running instance of
suave-gethto resolve the precompiles (statussubcommand).
Now, with the headless execution, we can skip step 2.
|
@ferranbt LMK if the process of cutting a new suave-geth release is painful in any way. I've still got fresh context on CI and am happy to dive back in to smooth out any friction points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the concept of local execution of the precompiles introduced in flashbots/suave-geth#185.
This PR requires a new release of
suave-gethdue to the changes in the commands. (CI fails because of that).Depends on #40